Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

em2go: add api.CurrentGetter #14436

Closed
wants to merge 1 commit into from

Conversation

RenatusRo
Copy link
Contributor

copycat of
0b52fd2
for Em2go Pro Power,
real life tested

try to hunt down
#14361

@RenatusRo RenatusRo changed the title Em2go: add api.CurrentGetter Em2go Pro Power: add api.CurrentGetter Jun 17, 2024
@premultiply
Copy link
Member

@andig Do we really need the two implementations em2go and em2go-home here?
The only difference between them is that em2go-home implemented phases1p3p.
Detect and decorate?

@premultiply premultiply changed the title Em2go Pro Power: add api.CurrentGetter em2go: add api.CurrentGetter Jun 17, 2024
@andig
Copy link
Member

andig commented Jun 18, 2024

I really don‘t know. Would be nice if we could detect.

@RenatusRo
Copy link
Contributor Author

if I call wb.conn.ReadHoldingRegisters(em2GoHomeRegPhases, 1)
on an em2go Pro Power it returns
*modbus.Error {FunctionCode: 255, ExceptionCode: 0}
so it looks like being detectable?
(BTW: em2go-home completely disappeared from their web site)

@andig andig mentioned this pull request Jun 19, 2024
@RenatusRo
Copy link
Contributor Author

closed as being obsoleted by #14480

@RenatusRo RenatusRo closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants